Instead of resetting the database after importing, pass through makeSelected = false#2626
Merged
robertbrignull merged 1 commit intomainfrom Jul 21, 2023
Merged
Conversation
shati-patel
approved these changes
Jul 21, 2023
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
LGTM! 🎈
Needs some testing for edge cases, but it seems to work for me.
Anything in particular? I did some testing, but definitely haven't covered every case!
Contributor
Author
Nothing in particular, just a bit more than I did. But if you've done it a couple of times and I did it a bit then I think that's enough to show it's working as well as it was before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For "model from source" and "model dependency" we were importing the new database, setting it as the current database, and then resetting the current database back to what it was before. Instead we can pass through
makeSelected = falseall the way toopenDatabaseand therefore not have to remember and reset the current database.Needs some testing for edge cases, but it seems to work for me.
Checklist
ready-for-doc-reviewlabel there.